Sarthak Nandi

We can check for unused classes, variables, and scopes.

Starting index on replica from a backup when the index is already downloaded before bugs out S3 download with the log `Not all bytes were read from the S3ObjectInputStream` being...

This results in an error like this: ``` Apr 06, 2021 3:33:40 PM com.yelp.nrtsearch.server.grpc.LuceneServer$LuceneServerImpl startIndex WARNING: error while trying to start index test_idx java.lang.IllegalArgumentException: index test_idx was not saved or...

`indices` in `GlobalState` is synchronized in the `getIndex` method: https://github.com/Yelp/nrtsearch/blob/6b2166948728e0a2c87b3c227b401781e0be38b6/src/main/java/com/yelp/nrtsearch/server/luceneserver/GlobalState.java#L234 This method is called in a lot of places (via another getIndex method) and we should consider removing the synchronization....

Different behaviors for start index in primary and replica

4

Following are the results when nrtsearch is started with restored state and start index is called: 1. Primary: start index fails with index not saved or committed message in exception...

This is required to be able to build nrtsearch inside an external docker container without dind.

Clearer exception: "Field \'" + name + "\' cannot be used in an expression: it was not registered with sort=true"

1

This error in FieldDefBindings: `throw new IllegalArgumentException("Field \'" + name + "\' cannot be used in an expression: it was not registered with sort=true");` is essentially thrown when either the...

Swagger operation IDs modified after protobuf version update

1

Due to https://github.com/grpc-ecosystem/grpc-gateway/pull/1193, we have `LuceneServer_` prepended to all operation IDs. The PR mentions that the maintainers will add a flag to go back to the previous behavior and we...

With #40 the predefined analyzers are only created with the no-args constructor. We should be able to specify the required params for them and use the right constructor.