Shawn M Moore

Results 17 comments of Shawn M Moore

We display lifecycle name in RTIR, so I'm on board with this. I'd even go one step further and use: Name%> rather than Queue for (Name%>) since "Queue for" just...

Hi Sam, Thanks for your patch. It's on our list to review and merge. :) Best, Shawn

I'm on board, in principal, with switching to openssl cms or openssl smime > @mkosmach commented on this pull request. > > In lib/RT/Crypt/SMIME.pm: > > > @@ -883,8 +884,18...

This looks pretty reasonable. As far as behavior goes, I'd suggest simply removing the `if ($config->{'type'} eq 'shib') {` check to let any `REMOTE_USER`-based system participate. For "more than 1-1...

Hi Einar, Sorry for the delay. > Yeah, concerning the type I wasnt sure if I'd simply call everything "remoteuser" or have a specific type for just shib. I finally...

That's not quite what I'm after. I'd say that the values for each ExternalSettingsRemoteUser (how about we rename that to `RemoteUserHeaders`) can be either: - a string (which means look...

Hi atus42. Thanks for your contribution. Could you explain in your commit message _why_ this change is being made? Why is breadth-first search better? The existing comment of "Howewer the...

I understand the context now. Thanks very much! I'll reword the commit message as I cherry-pick it into 4.2-trunk, so don't worry about that.

Hi atus42, it's still on my list to review. Sorry about the confusion.

Even just a few hundred milliseconds of delay would really improve the feedback. Having no delay (and no audible feedback) means that problems involving capture (especially throw-in) can be confusing,...