Paul-Edouard Sarlin

Results 249 comments of Paul-Edouard Sarlin

We can't provide support for forks of COLMAP so I suggest opening this issue there. FYI I expect that COLMAP will soon support such spherical images.

Is there a way to make this work with the new `Optional` type introduced in 2.13.0? Or any plan to fix this issue?

Indeed, the error precisely seems to occur because pyceres is installed (v2.3 in my case). Running `import pyceres` works fine. Uninstalling pyceres makes pycolmap work as expected. Also relevant: https://github.com/cvg/pyceres/issues/55

IDs are not indices, they are not ordered and are not guaranteed to be continuous. I think that image and point IDs usually start at 1 but most parts of...

`pycolmap.IncrementalMapperController` was renamed to `pycolmap.IncrementalPipeline` in 3.11. You are using `custom_incremental_mapping.py` at HEAD but, for COLMAP 3.10, you should be using this version of the file: https://github.com/colmap/colmap/blob/3.10/pycolmap/custom_incremental_mapping.py

Yes, the pose is refined with least-squares optimization following PnP+RANSAC. https://github.com/colmap/colmap/blob/0ea2d5ceee1360bba427b2ef61f1351e59a46f91/src/pycolmap/estimators/absolute_pose.cc#L42-L51

This is certainly useful, thank you! From now on, we want new Python code to live in pycolmap/pycolmap and to use the pycolmap APIs instead of the soon-deprecated database.py. Would...

You can find my email on my website or in the git logs of this repo.

We've never faced this before so, no, we don't have a proper process - but we'll consider adding so, thank you. In the meantime our inbox is open: https://github.com/colmap/pycolmap/blob/03f610f17924cf44a50a02222fe402095cb20571/pyproject.toml#L12-L14 (update...

Do we really need this level of complexity? I'm afraid that this implementation is over-generalized - we will likely never want to do SfM across UTM timezones. Converting all pose...