Daniel Ehlers

Results 30 comments of Daniel Ehlers

I have a written up algorithm description, but it is in no good shape. I am going to bring it into shape and add it to the repository.

Sorry, closed wrong issue. No it is not in openwrt/packages and yes I don't see why not have it there. When someone builds a package description.

I would, but I suspect we postpone this until we reach a more stable situation.

That fixed the problem for me.

@rotanid That a good thing, maybe someone can implement that, after the PR is through.

Good point. That code is kind of old and developed in hurry - so no code duplication is most likely. I try to clean it up a little more -...

I am not sure if this is the desired way of reducing code duplication. Maybe move utility function in own sub-module or integrate them into `oxidized/source/source.rb` , but they are...

> I think it's generic enough, because it has nothing to do technically with JSON, it's more navigating any ruby hash like object. There is a section method (CSV.open_file) that...

Yes, we are on the same page with the string_navigate method. The jsonfile source class had a second method duplicated from the csv source class open_file. Should I proceed with...

- moved and renamed `string_navigate` from `HTTP` to `Source` - moved `open_file` from `CSV` to `Source` - reduced remaining code redundancy between `HTTP` and `JSONFile` Please have a look.