Bruno Antunes

Results 37 comments of Bruno Antunes

Willing to improve https://github.com/amberframework/granite/pull/388 with some pointers!

I'll give it a shot. Thanks for having a look!

I have one open now (https://github.com/copiousfreetime/qup/pull/21). Would appreciate your help with the tests :/

I would remove https://github.com/copiousfreetime/qup/blob/redis-refactor/spec/spec_helper.rb#L26 just to not see the LoadError, but otherwise it LGTM :+1: (my contributing commit: https://github.com/sardaukar/qup/commit/5c50b0e16797c41f9982b057c996a2d99ace41ec) thanks for this! I might have some ideas for the Redis...

btw, couldn't get Kestrel to run locally, so didn't touch those tests

Hmm, not sure why the build failed - it passes locally for me on 2.1.5, with Redis 2.8.19

Oh, I see - I wasn't using Bundler, so I have newer versions of RSpec and such... do you want to update the dependencies?