mgpusim icon indicating copy to clipboard operation
mgpusim copied to clipboard

opcode 17 error

Open Yzgll opened this issue 1 year ago • 3 comments

I deleted the kernels.hsaco file and it didn't work after it was recompiled, so I added some instructions to fix the problem

Yzgll avatar Apr 29 '24 08:04 Yzgll

@Yzgll Just want to make sure, this version runs your newly compiled AES without error right?

syifan avatar Apr 29 '24 15:04 syifan

It seems that the unit tests are currently failing after being added. Can you help me fix them, @Yzgll? It can be problems with the test, if your AES code passes.

syifan avatar Apr 29 '24 15:04 syifan

It seems that the unit tests are currently failing after being added. Can you help me fix them, @Yzgll? It can be problems with the test, if your AES code passes.

It seems that the unit tests are currently failing after being added. Can you help me fix them, @Yzgll? It can be problems with the test, if your AES code passes.

Yeah, you're probably right, I don't do tests, so my test code is modeled after yours and it might be a little problematic. But I think the addition of opcode 17,42,0xA4 is correct, it helped me successfully run AES after recompiling and I was able to run it successfully without writing any tests on my own mgpusim.

Yzgll avatar Apr 30 '24 01:04 Yzgll