SmokeScreen icon indicating copy to clipboard operation
SmokeScreen copied to clipboard

Effects not showing on physicsless parts

Open DerpyFirework opened this issue 9 years ago • 6 comments

After trying to make RealPlume configs for certain engines, I noticed some parts won't show effects applied with SmokeScreen. After a few experiments, I found that parts with PhysicsSignificance = 1 in there configs will not show effects at all.

DerpyFirework avatar Jan 24 '16 11:01 DerpyFirework

Just looked in the SmokeScreen code, it seems it prevents particles when there is no rigidbody, which explains the problem. In these cases, would it be possible to use the parent parts' rigidbody instead?

DerpyFirework avatar Jan 24 '16 11:01 DerpyFirework

I am not seeing it after a quick scan of the code. Can you point me to that rigibody test and I ll see how many change it require.

sarbian avatar Jan 24 '16 11:01 sarbian

https://github.com/sarbian/SmokeScreen/blob/master/ModelMultiParticlePersistFX.cs#L266

DerpyFirework avatar Jan 24 '16 11:01 DerpyFirework

I've just done some testing with the modifications above, and the numbers returned in a simple test were identical to the numbers produced with the current method. Not saying that this is the solution, as there are likely issues somewhere, but plumes now show on physicsless parts

DerpyFirework avatar Apr 10 '16 11:04 DerpyFirework

physicsless parts should not be used at all except for some really specific cases. I am not adding a change that promote miss use of the part config.

Edit : and a physic less engine is wrong on so many point...

sarbian avatar Apr 10 '16 12:04 sarbian

Okay then, I'll see about resolving this on RealPlumes end then, by removing the PhysicsSignificance line. Thanks anyway!

DerpyFirework avatar Apr 10 '16 12:04 DerpyFirework