ModuleManager icon indicating copy to clipboard operation
ModuleManager copied to clipboard

Save File Backup

Open DMagic1 opened this issue 10 years ago • 3 comments

Your save file backup method can overwrite every .sfs file in the save file directory when it triggers, including the quicksave.sfs and any backup .sfs files present. I'm not sure exactly which circumstances trigger the plugin to create a backup folder, and overwrite the default files (needsBackup and needsSave both set to true).

Only the persistent.sfs should be updated, as the quicksave and any backup files may have been created for a reason and should not be overwritten, even if the backup folder contains the originals.

DMagic1 avatar May 26 '14 18:05 DMagic1

I guess this is a good point.

Not so sure about the quicksave however, possibly it should get fixed? Am intending to put a bit of UI controlling the whole process in the main menu anyhow.

Note that the fixing doesn't ever remove stuff - it can only ever take saves that aren't working and make them work. No information is removed from the save.

Swamp-Ig avatar May 26 '14 22:05 Swamp-Ig

Is there currently any indication that backups are being created? I only caught because all of the related yellow text in the debug window caught my eye, but obviously most people aren't going to have the debug window open during startup. Something more obvious would probably solve most of the issue.

DMagic1 avatar May 27 '14 20:05 DMagic1

I agree, some UI would be good.

Just got to actually do it.

Swamp-Ig avatar May 27 '14 23:05 Swamp-Ig