focus-indicator icon indicating copy to clipboard operation
focus-indicator copied to clipboard

Missing the hidden element warning

Open peterquale opened this issue 8 years ago • 2 comments

Hello! Is there a branch that still contains the hidden focused element warning? I found that super useful!

peterquale avatar Dec 14 '17 06:12 peterquale

The logic to detect invisible element was not correct and thus I removed it at https://github.com/sarbbottam/focus-indicator/commit/2c2dabb6665cb7b13d10448a92cc23bd774ec93d. I had no idea that it was being used, or else I wouldn't have removed it. I would find some time to get it back. However, please feel free to raise a PR. Thanks!

sarbbottam avatar Dec 14 '17 15:12 sarbbottam

Ah. Got it. Thanks. I love it and recommend to clients and cohorts often. No pressure to bring it back if, of course. Should you reconsider, it would be awesome to include the focused element in the warning like: +div.innerHTML = 'Invisible element ' + document.activeElement + ' is focused.'; Thanks for such a useful tool!

peterquale avatar Dec 14 '17 17:12 peterquale