flutter_tagging icon indicating copy to clipboard operation
flutter_tagging copied to clipboard

Provide an equality check function instead of messing with class hierarchies

Open Grohden opened this issue 4 years ago • 2 comments

This package seems great, is just what I need, but unfortunately I have to change my classes hierarchies to be able to use it

It would be nice to have a equality check function passed as a prop to the widget instead of adding a new class hierarchy

Btw, I'm using a personal custom modified version of the package just so I can get rid of the taggable class, if you wish I could make a PR

Grohden avatar Aug 01 '20 19:08 Grohden

Can you make a PR? I would be interested in that.

bradintheusa avatar Oct 16 '21 19:10 bradintheusa

@bradintheusa I'm not sure if I will be able to open a PR in the near future..

But you can take a look at my changes and open a PR if you wish: https://github.com/Grohden/repo-tagger/blob/master/frontend/lib/external/taggable/tagging.dart

Edit: I called the equality check prop areObjectsEqual

Grohden avatar Oct 17 '21 00:10 Grohden