Saransh Sharma

Results 21 comments of Saransh Sharma

I have tested the PR the command `./bitcoin-cli -signet verifychain 4 1000` returns true , does it requires tests to be written ?

You mean changing the RPC return response prior adding objects for warning and error, ``` static RPCHelpMan verifychain() if warning then (display Warning) if error then (display Error) or else...

> verifychain The above methods aborts, the code does produce assertion and thus abort, are you suggesting that it should rather identify for the user to simply ignore or warn...

Right, so it should be taken care by default or by input, as in this there is an input , so that means a user is always triggering the output....

I was under the assumption that you are talking about VerifyDB() handling the checks like the above on its own on the startup, rather the rpc doing the check !

@darkskygit This one could be merged thanks !

hey @darkskygit any updates?

I guess this can done let me know, but considering the current setup it would need more dependency to work with !

@thozinza and @thotrung

I have added the editor JS let me know how it works