Sarah Boyce

Results 64 comments of Sarah Boyce

Merged in 9cf9c796be8dd53bc3b11355ff39d65c81d7be6d :+1:

> I apologize for the recent silence, I'm currently busy. I just wanted to know how to proceed with the docs/releases/5.1.txt file, since Django 5.1 is out. Should I transfer...

```diff diff --git a/django/contrib/admin/static/admin/css/forms.css b/django/contrib/admin/static/admin/css/forms.css index 539a11ae61..be1a1b8174 100644 --- a/django/contrib/admin/static/admin/css/forms.css +++ b/django/contrib/admin/static/admin/css/forms.css @@ -491,7 +491,8 @@ body.popup .submit-row { .related-lookup { margin-left: 5px; display: inline-block; - vertical-align: middle; + margin-top:...

Thank you for your work on this @salvo-polizzi ⭐ I will be merging #18325 shortly and so will close this PR

> @hugovk It did not fail on 3.12 for the CI: https://github.com/foarsitter/dropbox-sdk-python/actions/runs/6707504248 @foarsitter this is because `requirements.txt` also includes some requirements for development including `sphinx` which installs `setuptools`. Ref raw...

> @sarahboyce Can you give some clarification on what "unexpected results" you are seeing with the current implementation? This should be mostly captured by this ticket to Django: https://code.djangoproject.com/ticket/34028 `get_script_prefix`...

> Yes, updates look good. However, I didn't receive any answer about my question on the ticket, that is if the use case of not accepting internationalized domains is still...

As your PR got merged, perhaps we should switch to that rather than document what `pycon` means?

> However, that scenario (removing a primary key from a table so the table is empty) is failing on mysql, saying we have to use DROP TABLE instead of removing...

> @sarahboyce It looks like in [Schema.remove_field](https://github.com/django/django/blob/main/django/db/backends/base/schema.py#L788) I could check to see if the model has no fields left, and if so, I could switch it to a `delete_model` call?...