Sarah Boyce
Sarah Boyce
> Consider an archived team with active members: unless I misunderstood those members would not be listed on the new archive page. They are listed, see alice in `test_archived_team`
Thank you for this @LeOndaz :star: I think as we are doing this to allow people to extend this, we should treat this as a new feature and so this...
> @sarahboyce I should be documenting the Autodetector generally, not just the feature, since it's not documented afaik, right? > > I'm tempted to document the migration execution flow here...
> I guess 🤔 so for now tests without docs ? maybe we should ask for a third opinion, what do you think Let's add tests and a release note...
See `tests.admin_scripts.tests.CommandTypes.test_custom_stdout` where a command is defined in the test and use `call_command` on it directly like... ```python out = StringIO() command = Command(stdout=out) call_command(command) ```
As an example in the `makemigrations` case, I was thinking something like: ```diff --- a/tests/migrations/test_commands.py +++ b/tests/migrations/test_commands.py @@ -2801,6 +2801,32 @@ class MakeMigrationsTests(MigrationTestBase): with self.assertRaisesMessage(CommandError, msg): call_command("makemigrations", "book_app", update=True) +...
I agree it _feels_ like a setting, but the issue is a lot of things feel like a setting and we try to prevent this from becoming a dumping ground....
> @sarahboyce I can see some tests are failing, but I didn't touch them, can you check when you have the time? The test failures are related. Looks like there...
> @sarahboyce I think the failing doc test shouldn't be fixed, it's because I referenced the autodetector, but it doesn't yet have something to reference, but having it now is...
If I was to make changes I would: - move "Creating projects with a local copy of Django" to https://docs.djangoproject.com/en/5.2/internals/contributing/writing-code/unit-tests/ with a title more like "Manual testing against an existing...