Sarah Boyce
Sarah Boyce
Fixed #32095 -- Changed update_or_create to only save auto_now fields and fields listed in defaults.
> @sarahboyce Thanks for this patch +1 Some comments from the original patch are not addressed: > > * https://github.com/django/django/pull/13526/files#r503304168 > * [#13526 (comment)](https://github.com/django/django/pull/13526#issuecomment-706707674) > > Can you take a...
Fixed #32095 -- Changed update_or_create to only save auto_now fields and fields listed in defaults.
I realise I will probably not be popular for adding freeze_gun into the testing requirements. I was having that all tests except the windows runner tests were passing and I've...
@evansd @adamchainz I've now added a changelog, I think this is ready for a review :+1:
Hi @tushar5526 👋 great to see you! Can you add to the `django.server` logging docs that response time is also included (https://docs.djangoproject.com/en/dev/ref/logging/#django-server). It will also need a `.. versionchanged:: 5.1`...
Hi @HamaBarhamou, thank you for adding the test for `abulk_create` and the formatting changes ⭐ 🎉 A couple of things have been missed - Please update the release notes based...
The backend postgres tests are not designed to pass with a pool as they for example check that there is no pool and change the settings. The test cleanup would...
``` FAILED (failures=102, errors=13, skipped=380, expected failures=7) ``` I have basically the same. I can try to rewrite the backend tests that they would pass with the change of underlying...
> Btw we should probably create a new ticket for this so we have something to mark as "ready to review"? :D Tracking with this ticket for now: https://code.djangoproject.com/ticket/33497 But...
> @sarahboyce would you have an opinion with your fresh view? Nothing fresh to offer, commit 1 and inverting the documentation makes sense to me 👍
@devin13cox we can add asserts to `SeleniumTests.test_related_object_update_with_camel_casing` rather than creating new models/admin/test for this case ```diff --- a/tests/admin_views/test_related_object_lookups.py +++ b/tests/admin_views/test_related_object_lookups.py @@ -117,3 +117,6 @@ class SeleniumTests(AdminSeleniumTestCase): {interesting_name} """, ) +...