gemm icon indicating copy to clipboard operation
gemm copied to clipboard

Regarding Panic Comment in gemm.rs

Open mert-kurttutan opened this issue 1 year ago • 1 comments

There is a comment in the code base: https://github.com/sarah-ek/gemm/blob/main/gemm/src/gemm.rs#L151

which says that gemm panics if T is not f32 and f64. But I was able to run it with f16 type as well.

I guess this is a typo since the function is also used by gemm_dispatch function to matmul on f16 data type ??

mert-kurttutan avatar May 15 '23 11:05 mert-kurttutan

yeah, the comment there is outdated. thanks for pointing it out

sarah-quinones avatar May 16 '23 13:05 sarah-quinones