gemm icon indicating copy to clipboard operation
gemm copied to clipboard

Add GemmType trait for dispatching gemm fn calls

Open ivarflakstad opened this issue 1 year ago • 2 comments

I was wondering if this change would be of interest. Removes the if-else-panic and let's the type system take care of that constraint instead.

ivarflakstad avatar Oct 26 '23 23:10 ivarflakstad

thanks for the PR! though im not really sure if i want this. having no bounds is useful for usage in generic libraries, which is where the library is meant to be used. i'd prefer to leave it up to the consumers of the library to implement such a wrapper

sarah-quinones avatar Oct 27 '23 21:10 sarah-quinones

Hmm I see, that's a valid point. Still I want to emphasize that it is the exact same "bounds" as were there originally - except it was expressed through if statements.

So the only change I can see is that it will fail to build rather than panic at runtime.

ivarflakstad avatar Oct 27 '23 22:10 ivarflakstad