sicp icon indicating copy to clipboard operation
sicp copied to clipboard

Incorrect images in Chapter 2

Open bricef opened this issue 9 years ago • 2 comments

Problem with images

Figures 2.9 and 2.14 are incorrect and do not reflect the code in the book, or the original images.

Compare this repository's Figure 2.9 and the original.

We can see here that the limit is not interpreted in the same way, with this repo's images having more instances of the original picture than the book's images.

Compare this repository's Figure 2.14 and the original.

We can see that for example, the (right-split rogers 4) example in the book has 5 image layers, while this repository's example has 6. This is especially obvious with the corner-split examples, as the top-right corner is quite different in style.

Note on correctness

I think that this repository's images better reflect the intent of the square-limit idea. However, they do not match the code and are not a faithful representation of the original work, so should be replaced.

bricef avatar May 28 '16 14:05 bricef

Note that I would be happy to provide high resolution bitmaps with the correct images if needed, from the wiki commons original of Rogers or the wave file if it is made available.

bricef avatar May 28 '16 14:05 bricef

Good observation, thanks. I corrected the code below the images (https://github.com/sarabander/sicp/commit/e2d0b6233f9372a7b39a5c20ebf8e0ac7cc4da5f) as I prefer to see more layers on the picture. I'm not too concerned to remain faithful to the original in every detail.

Actually, the square-limit pictures could benefit from a redesign. It would be a good excuse to learn the Haskell Diagrams package or similar.

sarabander avatar May 29 '16 14:05 sarabander