sourcemod-nativevotes-updated icon indicating copy to clipboard operation
sourcemod-nativevotes-updated copied to clipboard

Votes broken in MvM

Open SomeDeadGirl opened this issue 3 months ago • 2 comments

L 08/29/2025 - 23:16:09: [asc_dependencies/nativevotes_mapchooser.smx] Starting map vote because outside request
L 08/29/2025 - 23:16:09: [SM] Exception reported: Client 99 is fake and cannot be targeted
L 08/29/2025 - 23:16:09: [SM] Blaming: asc_dependencies/nativevotes.smx
L 08/29/2025 - 23:16:09: [SM] Call stack trace:
L 08/29/2025 - 23:16:09: [SM]   [0] ConVar.ReplicateToClient
L 08/29/2025 - 23:16:09: [SM]   [1] Line 2375, nativevotes/game.sp::TF2CSGO_DisplayVote
L 08/29/2025 - 23:16:09: [SM]   [2] Line 649, nativevotes/game.sp::Game_DisplayVote
L 08/29/2025 - 23:16:09: [SM]   [3] Line 1209, nativevotes.sp::DoClientVote
L 08/29/2025 - 23:16:09: [SM]   [4] Line 1183, nativevotes.sp::StartVote
L 08/29/2025 - 23:16:09: [SM]   [5] Line 1642, nativevotes.sp::Native_Display
L 08/29/2025 - 23:16:09: [SM]   [7] NativeVote.DisplayVote
L 08/29/2025 - 23:16:09: [SM]   [8] Line 384, ./include/nativevotes.inc::NativeVote.DisplayVoteToAll
L 08/29/2025 - 23:16:09: [SM]   [9] Line 807, nativevotes_mapchooser.sp::InitiateVote
L 08/29/2025 - 23:16:09: [SM]   [10] Line 1502, nativevotes_mapchooser.sp::Native_InitiateVote
L 08/29/2025 - 23:16:09: [SM]   [12] InitiateMapChooserVote
L 08/29/2025 - 23:16:09: [SM]   [13] Line 375, nativevotes_rockthevote.sp::StartRTV
L 08/29/2025 - 23:16:09: [SM]   [14] Line 337, nativevotes_rockthevote.sp::AttemptRTV
L 08/29/2025 - 23:16:09: [SM]   [15] Line 269, nativevotes_rockthevote.sp::Command_RTV

SomeDeadGirl avatar Aug 29 '25 23:08 SomeDeadGirl

I did my own fix but I would like you to add this into the official repo:

game.sp

if (!isTF2SDKModHack)
    {
        int holder = vote.Initiator;
        // required to allow the initiator to vote on their own issue
        // ValveSoftware/Source-1-Games#3934
        if (sv_vote_holder_may_vote_no && holder <= MaxClients && IsClientConnected(holder)) && !IsFakeClient(holder)
        {
            sv_vote_holder_may_vote_no.ReplicateToClient(holder, "1");
        }
    }

SomeDeadGirl avatar Aug 31 '25 18:08 SomeDeadGirl

If you open a PR I can test and merge this 👍

sapphonie avatar Sep 02 '25 20:09 sapphonie