StAC-tf2 icon indicating copy to clipboard operation
StAC-tf2 copied to clipboard

Fix detection for SMAC core and module plugins

Open sirdigbot opened this issue 9 months ago • 4 comments

Fix for #198

All the official SMAC stuff starts with "SMAC " (with trailing space) except for the core plugin which is "SourceMod Anti-Cheat" Not sure if there's and "[SMAC]" variants out there or not ¯\_(ツ)_/¯

sirdigbot avatar May 10 '24 02:05 sirdigbot

yo hold up this fix doesn't work 😎

sirdigbot avatar May 10 '24 03:05 sirdigbot

romcom scribes have nothing on this

Mooshua avatar May 10 '24 05:05 Mooshua

what about checking for the smac library for a more reliable result https://github.com/Silenci0/SMAC/blob/aa4cf68ab8b5f46ac59e7d94de9a936ef7704e4a/addons/sourcemod/scripting/smac.sp#L174

or the smac_wallhack library https://github.com/Silenci0/SMAC/blob/aa4cf68ab8b5f46ac59e7d94de9a936ef7704e4a/addons/sourcemod/scripting/smac_wallhack.sp#L91

maxijabase avatar May 10 '24 17:05 maxijabase

i'll leave it for sapphonie to decide what approach is better since i dont particularly care either way

sirdigbot avatar May 11 '24 00:05 sirdigbot

GetFeatureStatus(FeatureType_Capability, "SMAC_Ban");?

sapphonie avatar May 14 '24 23:05 sapphonie

#201

sapphonie avatar Jun 30 '24 03:06 sapphonie