Sapphire Koser

[DRAFT] Add tests for the voice code

1

This is looking like it's going to pull in a whole bunch of nonsense along with the voice code, so that might get submitted as separate PRs first.

### Please describe the problem: The clip level filter menus change the entry name and title for the morph parameter depending on the filter mode (SVF gets morph, ladder filters...

OLED is not correctly reset on boot

2

Occasionally after flashing (either via sysex or via the SD bootloader) the OLED column pointer ends up somewhere offset and the whole display is aligned. In principle the `0x22` and...

Unify Transpose

1

There are currently (at least) 6 separate representations of "Transpose" internally: - Almost every `Output` type has its own transpose, but they're not stored uniformly: - `AudioOutput` doesn't store it...

We can't change the intensity of flashing in the upper section (play/record/etc.) as those LEDs are only on or off, but we could audit how we use high-contrast flashes on...

When loop lock is engaged, the loop can not be moved towards the other endpoint if the endpoints are adjacent

1

### Please describe the problem: If a loop is locked and the start/end of the loop are adjacent, trying to move the loop start right or the loop end left...

Waveform loop lock (and loop length) should be remembered between loop endpoints being taken in and out of the loop

1

After #844, loop lock state is forgotten when loop points are removed. Instead, that state should be retained and restored when the loop points are present again. Important considerations: -...

Snap-to-zero-crossing in waveform editor

5

From a discussion on Discord earlier today: https://discord.com/channels/608916579421257728/1118654563596128336/1121185820854980678 In the waveform editor, the following shortcuts should work: - Vertical scroll encoder should swap the currently selected endpoint in the order...

**Is your feature request related to a problem? Please describe.** When loading files that include unfilled zones on the User.* layers, the line work can be difficult to read if...

[DRAFT] Timeline position indicator

1

Uses the OLED to provide visual context about where the current view is in relation to the total clip lengths. - [ ] Add playhead indicator - [ ] Add...