Stefan Appelhoff
Stefan Appelhoff
https://github.com/mne-tools/mne-python/blob/ac2c4c0d72f9843690aad70e63b48269f5269a0f/mne/_fiff/meas_info.py#L317 see: https://mne.tools/stable/generated/mne.io.Raw.html#mne.io.Raw.get_montage  ☝️ The description is as if this were a parameter, not a return value. Furthermore, it should specify that this returns a copy of a montage,...
Users can use RANSAC in the way that is described in this example: https://pyprep.readthedocs.io/en/latest/auto_examples/run_ransac.html#sphx-glr-auto-examples-run-ransac-py No need to private two routes to the same goal.
https://pyprep.readthedocs.io/en/latest/generated/pyprep.Reference.html# From my point of view, users should call `pyprep.PrepPipeline(...).fit()`, which then calls the `Reference` class and its methods in the correct order. Please respond here if you think this...
The matprep repository by @a-hurst has been super helpful, but it also (understandably) hasn't received a lot of updates in the past: https://github.com/a-hurst/matprep_artifacts I think for maintainability, we should: 1....
See for example: https://github.com/sappelhoff/pyprep/blob/82390acff4c15a8e8ca92ed92c46f7a50d72e049/pyprep/find_noisy_channels.py#L57 This raises: > NOTE: pick_types() is a legacy function. New code should use inst.pick(...).
We are still using numpy's old random API in many places. It would be good to migrate to the recommended `np.random.default_rng`. This might turn out to be difficult, given our...
PR Description -------------- - xref: #1288 Trying to add the schema validator to our CI Merge checklist --------------- Maintainer, please confirm the following before merging. If applicable: - [ ]...
Currently there are two BIDS validator "builds": 1. the "legacy" validator, implemented mainly with custom Java Script 2. the "schema" validator, based on the [BIDS schema](https://bids-specification.readthedocs.io/en/stable/appendices/schema.html) We use the legacy...
we still use `op.join` in many cases that could be simplified with the `pathlib` syntax of concatenation via `/`.
similar to what MNE-Python has at the bottom of their landing page, but perhaps more detailed? xrefs: - https://github.com/mne-tools/mne-python/issues/11605#issuecomment-2225073499