Stefan Appelhoff

Results 642 comments of Stefan Appelhoff

> When doing things like this, we need to be careful to write things in such a way as to only peek at the portions needed. with NIfTI, is this...

> I don't have a lot of bandwidth but certainly interested in a "javascript nibabel for ephys" now we are two :heart_eyes: But if that code is online, it'd help...

@antotorov do you still have the issue with v1.7.2? PET validation should be much better now compared to when you ran into the error with v 1.6.2.

it's possible that all that's needed is an edit of https://github.com/bids-standard/bids-validator/blob/master/bids-validator/bids_validator/rules/top_level_rules.json -- so I think if you are keen, you could look into that?

> Empty string as a key is an error That can probably be done in JSON schema terms via: ```json { "not": { "anyOf": [ { "required": [ "" ]...

The bids-validator currently contains a check for the `IntendedFor` field as part of the NIfTI validation: https://github.com/bids-standard/bids-validator/blob/4feb91b8aa9506c123d38327485dd5d4cd69e80b/bids-validator/validators/nifti/nii.js#L1247-L1265 This leads to issues during validation with BIDS URIs, see this bids-examples PR:...

> I'm not sure we can do more than warn here without invalidating strings. At least for `onset` and `duration` we can perform a "strong" validation (with errors). For other...

I got the same issue with the docker image after `datalad clone`ing a dataset and running `bids-validator` without `datalad get`ting all files first. I agree that an error message instead...

**EDIT**: Looking back at this after a while it took me a time to see what's wrong: In participants.tsv, the participant_id column contains **subj-**, not **sub-** The issue I see...

Actually, a check for this is in place here: https://github.com/bids-standard/bids-validator/blob/b542235df3579ed1328058ad41777c5dd96d2d73/bids-validator/validators/bids/fullTest.js#L163-L169 using this function: https://github.com/bids-standard/bids-validator/blob/b542235df3579ed1328058ad41777c5dd96d2d73/bids-validator/validators/bids/subjects.js#L1-L62 and this issue code: https://github.com/bids-standard/bids-validator/blob/b542235df3579ed1328058ad41777c5dd96d2d73/bids-validator/utils/issues/list.js#L273-L277 the question is ... why is it not triggered? Any idea...