Marcin Cieślak
Marcin Cieślak
@mankinchi can you build a simple repository with a script to demonstrate this?
Yes. That is how it should be, but it does not work. Paths added from behind the condition will be merged in, but they get appended regardless of + We...
Can you try putting your binding in the following directory structure: ```` > find /tmp/node /tmp/node /tmp/node/linux-x64-72 /tmp/node/linux-x64-72/binding.node ````
Same output (with https://github.com/sass/libsass/pull/1288 enabled as well): https://gist.github.com/saper/43dbc3c050553d035692
ping! it merges with the current master :) https://github.com/sass/node-sass/commit/7c15014b594f2b9e85b72cab89e2aca56762e740
Nope, it has the same implementation though (could be shared maybe). Will work on this, since it has proven already useful e.g. to triage out libsass bugs.
On Fri, 29 Apr 2016, Michael Mifsud wrote: > @saper is this something you still want? yep.
I don't think that "null instanceof sass.types.Null" could be made true, I'd rather modify our test instead (not to depend on the implementation internals).
It takes around of 15 minutes of running a pared-down version of `tests/cli.js` in a loop to reproduce those as above: ``` time sh -c 'while node_modules/.bin/mocha test/xcli.js ; do...
I also feel there's something wrong in https://github.com/sass/node-sass/blob/f6b5fd2de527a4cba599c6b38797a227463decb2/bin/node-sass#L247-L258 I'd love to have this moved to `lib/watch.js` and be properly tested internally.