sapegin
(light) High contrast no italics version
👋 hello
Since I made this variant, I wanted to share it in case someone else needs more contrast (on token, not VSCode ui)
Hey,
High contrast variant is a good idea overall, though, implemented this way (hardcoded next to the normal theme) is unmaintainable. The right way would be to generate the themes using a script:
https://github.com/sapegin/squirrelsong/blob/master/scripts/prepare-vscode.mjs
Oh yes true! Do you mean something like Rose Pine, using tokens? https://github.com/rose-pine/vscode/blob/main/themes/_pinecone-color-theme.json
I think it's a good idea in theory but will be very hard to debug in practice.
We already generate light theme with dark terminal for VS Code based on main light and dark themes. We can use similar approach to generate additional themes:
- High contrast: replace low contrast colors with high contrast variations.
- No italic: remove italic attribute from styles.
- And so on.
This way we only need to maintain one light theme.
And I guess the same approach can be used for other apps.