mrm icon indicating copy to clipboard operation
mrm copied to clipboard

fix(eslint): add prettier rules if installed without TS

Open simonflk opened this issue 4 years ago • 6 comments

The problem

Currently, the task will only add the prettier rules if Typescript is also installed.

What was changed

  • [x] add eslint-config-prettier if prettier is installed, regardless of TS

simonflk avatar Apr 19 '20 16:04 simonflk

why this is not merged yet?

FDiskas avatar Nov 17 '20 22:11 FDiskas

The problem is, not everyone needs this thing (even for TypeScript, so we need a way to disable this behavior).

sapegin avatar Nov 18 '20 06:11 sapegin

this can be as a question in interactive mode.

FDiskas avatar Nov 19 '20 10:11 FDiskas

Also I would suggest to add https://github.com/prettier/eslint-plugin-prettier Currently prettier can help eslint to autofix styling issues.

FDiskas avatar Nov 19 '20 10:11 FDiskas

this can be as a question in interactive mode.

Yep.

Also I would suggest to add https://github.com/prettier/eslint-plugin-prettier Currently prettier can help eslint to autofix styling issues.

I believe you can already define it in your config but we won't have it by default (or even with an option) because of the very bed developer experience it creates. We shouldn't treat unformatted code as an error and distract developers but format it silently on commit.

sapegin avatar Nov 19 '20 12:11 sapegin

All major IDE has built-in ability fix eslint issues on save and this is not bad expanse for fast developing

FDiskas avatar Nov 26 '20 00:11 FDiskas