mrm
mrm copied to clipboard
WIP: feat: update eslint/prettier configs
@sapegin -- this is NOT ready for release yet, but wanted to show you my current code.
The latest eslint-config-prettier simplifies things considerably, so I updated my eslint task to migrate to the latest config.
Additionally, I added support for yarn and vue (both require some tweaks to the base code).
LMK if you want me to pursue this -- I'll have to fix the tests and see what else needs to be done
Looks good so far!
There are two issues with the current approach in general (not with this pull request, these are more of thinking loud):
- Messy code with lots of conditions that's hard to read and maintain.
- No way to disable all the magic, which could be necessary when you use your own preset that may already include the plugins.
Hello @sapegin!
Is this still being worked on?
As of prettier v8 https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21, current mrm prettier setup creates a config that produces an error:
Error: Cannot read config file: `/
/node_modules/eslint-config-prettier/@typescript-eslint.js Error: "prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0. See: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21
Will this PR be merged eventually or should I help create a new one which just solves the above issue?
@everdimension Please open a new pull request, thanks!