mrm icon indicating copy to clipboard operation
mrm copied to clipboard

[mrm-task-eslint] `prettier/@typescript-eslint` is no more needed.

Open riywo opened this issue 4 years ago • 0 comments

When I ran mrm typescript prettier eslint, mrm added prettier/@typescript-eslint to .eslintrc.json. However, with the latest version of eslint-config-prettier, eslint won't work:

Error: Cannot read config file: /Users/riywo/riywo.com/app/node_modules/eslint-config-prettier/@typescript-eslint.js
Error: "prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0. See: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21
Referenced from: /Users/riywo/riywo.com/app/.eslintrc.json

I think we can remove prettier/@typescript-eslint from here:

https://github.com/sapegin/mrm/blob/ca485fb1b3dc7c36f67773ed0f6980126e2fbf3e/packages/mrm-task-eslint/index.js#L121-L128

I confirmed eslint works once I removed prettier/@typescript-eslint by hand.

riywo avatar May 06 '21 08:05 riywo