grunt-webfont icon indicating copy to clipboard operation
grunt-webfont copied to clipboard

allow flexible width using fontforge engine

Open mstorus opened this issue 9 years ago • 4 comments

Using the fontforge engine doesn't allow for icons to retain the width set in their respective SVG files. The width is currently either normalized to fit the width of the glyph or set to the font height

https://github.com/sapegin/grunt-webfont/blob/c2a4d0583d19c19d4beda843c0e746c1f08a0d4b/tasks/engines/fontforge/generate.py#L69-L73

The node engine by default (through the use of svgicons2svgfont), uses a width derived from the width defined in the SVG file. https://github.com/nfroidure/svgicons2svgfont/blob/a38783a7271b8aec314811afd68791b84c8e95cf/src/index.js#L49 https://github.com/nfroidure/svgicons2svgfont/blob/a38783a7271b8aec314811afd68791b84c8e95cf/src/index.js#L91-L109

I think it would be nice to have the fontforge engine also allow individual widths derived from the widths defined in the SVG files.

mstorus avatar Sep 29 '14 18:09 mstorus

Yep, it would be nice. Pull requests are welcome.

sapegin avatar Nov 13 '14 12:11 sapegin

No news on this?

Hendrikto avatar May 28 '15 14:05 Hendrikto

Also maybe this disadvantage of using fontforge engine should be documented in README?

thybzi avatar Feb 20 '16 16:02 thybzi

@thybzi Same answer: pull requests are welcome ;-)

sapegin avatar Feb 20 '16 19:02 sapegin