grunt-bower-concat icon indicating copy to clipboard operation
grunt-bower-concat copied to clipboard

Bootstrap Update Breaks Things

Open james-logan opened this issue 9 years ago • 5 comments

Hey guys, a bootstrap update that got released a few hours ago is causing this to break. Bootstrap is no longer being added to the destination files when bower-concat is run.

Here's the update which I think is the culprit: https://github.com/twbs/bootstrap/commit/38861984d9035333e2b366d307a5b874df8b8759#diff-0a08a7565aba4405282251491979bb6b

They removed dist/css/bootstrap.css from their main files.

Thanks, James

james-logan avatar Jun 16 '15 20:06 james-logan

Having the same issue, seems to be breaking wire-dep as well.

mattfili avatar Jun 18 '15 18:06 mattfili

+1

afmacedo avatar Jun 19 '15 01:06 afmacedo

bower_concat: {
      main: {
        dest: 'public/lib/build.js',
        cssDest: 'public/lib/build.css',
        mainFiles: {
          bootstrap: 'dist/css/bootstrap.min.css'
        }
      }
    }

Here's a work around for the time being in my Gruntfile.js. Inside of 'main' I added 'mainFiles' to indicate a specific file to search for.

james-logan avatar Jun 19 '15 14:06 james-logan

Relevant Issues: https://github.com/twbs/bootstrap/issues/16663 https://github.com/bower/bower.json-spec/pull/43 https://github.com/bower/bower.json-spec/issues/47

sscotth avatar Jun 22 '15 18:06 sscotth

@james-logan thanks for the workaround, but I think the js should be included as well if this is supposed to work as before the broken update:

mainFiles: {
    bootstrap: [ 'dist/css/bootstrap.min.css', 'dist/js/bootstrap.min.js' ]
}

One might want to include the glyph fonts too, since: https://github.com/twbs/bootstrap/commit/6cb9d6ce015f5a986974121799daf264441bbe5f was also made without a version bump.

kuonirat avatar Jul 07 '15 09:07 kuonirat