[manila] fix null availablity_zone_names in sql metrics

[chuan137]

[majewsky]

That will not be effective since you're doing JOIN availability_zones, so if no AZ reference is available, the join will discard the row. You would need a LEFT OUTER JOIN there, and then I'm not sure how the GROUP BY behaves on a null value in the grouping column.

[chuan137]

with LEFT OUTER JOIN, the query works better,

MariaDB [manila]> SELECT coalesce(share_instances.share_type_id, 'N/A') AS share_type_id, coalesce(availability_zones.name, 'N/A') AS availability_zone_name, share_instances.host AS manila_host, shares.project_id, shares.id, share_instances.id AS share_instance_id, share_instances.status,  COUNT(*) AS count_gauge FROM shares JOIN share_instances ON shares.id=share_instances.share_id LEFT OUTER JOIN availability_zones ON share_instances.availability_zone_id=availability_zones.id WHERE share_instances.deleted = 'False'         AND share_instances.replica_state='active' AND shares.id = '61b4e82c-3d81-4cb8-8d40-cba7ddfbb0dd'   GROUP BY           share_instances.share_type_id,  manila_host,  share_instances.status, shares.id, shares.project_id, availability_zones.id ;
+--------------------------------------+------------------------+----------------------------------------------------------------------+----------------------------------+--------------------------------------+--------------------------------------+-----------+-------------+
| share_type_id                        | availability_zone_name | manila_host                                                          | project_id                       | id                                   | share_instance_id                    | status    | count_gauge |
+--------------------------------------+------------------------+----------------------------------------------------------------------+----------------------------------+--------------------------------------+--------------------------------------+-----------+-------------+
| 2e09de1f-32e6-42b4-a74d-4cda4e65a04c | N/A                    | manila-share-netapp-ma01-st062@ma01-st062#aggr_ssd_stnpa3_01_st062_1 | 4ff2cfd47d084070ae3a429c41d126c9 | 61b4e82c-3d81-4cb8-8d40-cba7ddfbb0dd | f1f5b94e-277f-480b-b21b-ca7b956cda16 | available |           1 |
+--------------------------------------+------------------------+----------------------------------------------------------------------+----------------------------------+--------------------------------------+--------------------------------------+-----------+-------------+

[sapcc-bot]

Failed to validate the helm chart. Details. Readme.