community.sap_install icon indicating copy to clipboard operation
community.sap_install copied to clipboard

Collection: Define collection dependency for community.general

Open berndfinger opened this issue 10 months ago • 2 comments

... in an attempt to solve issue #716.

berndfinger avatar Apr 18 '24 08:04 berndfinger

@berndfinger @Wabri There seems to be something with Checks, datas > data is clear typo, but they all failed.

marcelmamula avatar Apr 19 '24 10:04 marcelmamula

@marcelmamula hi marcel, the pr was merged yesterday with all the check passed you can see here https://github.com/sap-linuxlab/community.sap_install/pull/718 and in the dev branch there are no references to datas https://github.com/sap-linuxlab/community.sap_install/blob/4636753597d67619e8e06091052dcb7b23e5ebc1/workflows/check_outdate_deps/check_deps.py#L238

I think the problem is that both actions use the default branch when checkout: https://github.com/sap-linuxlab/community.sap_install/blob/4face938e1ba5009aff0dd58d0c8a251f04c719a/.github/workflows/codespell.yml#L17 https://github.com/sap-linuxlab/community.sap_install/blob/4face938e1ba5009aff0dd58d0c8a251f04c719a/.github/workflows/ansible-test-sanity.yml#L20

You can see the documentation here https://github.com/actions/checkout?tab=readme-ov-file#usage

In order to solve this problem we can set the checkout to the base branch of the pr, or for now just skip it until the dev branch is not merged to the main branch.

Wabri avatar Apr 19 '24 11:04 Wabri