Santiago Soler
Santiago Soler
#### Summary Add checks to validate the `survey` and `lineID` inputs in the `convert_survey_3d_to_2d_lines` function. Add tests to check if errors are raised after passing invalid arguments. Improve the docstring...
#### Summary Remove `**kwargs` from the constructor of the class, add `current` as one of the arguments. Improve the logic and error messages for the `location`, `location_a` and `location_b` arguments....
Replace the usage of legacy `numpy.random.seed()` in SimPEG codebase for the Numpy random number generator object that can be created through the `numpy.random.default_rng()` function. Add a new `typing` module that...
### Issue with current documentation: After merging #1430 was merged, we deprecated the `SimPEG` package in favor for its pep8 compliant name: `simpeg`. I noticed that we haven't applied any...
I think it would be nice to continue the discussion regarding the usage of `**kwargs` in class constructors and their role in inheritance. In past meetings I've expressed my desire...
In the meeting of 2024-04-10 we discussed about modifying the interface of the constructor of the `UniformBackgroundField` class. One idea that floated around was to make the `amplitude`, `inclination` and...
@dccowan noticed that there are some legacy tests living in SimPEG codebase (inside the `SimPEG` folder) instead of being with the other tests (inside the `tests` folder). One example of...
### Issue with current documentation: Currently the docstring for `SimPEG.electromagnetics.static.resistivity.sources.Dipole` ask the `location_a` and `location_b` to be 2d arrays with shape `(n_source, dim)`. From what I understand, these arrays should...
As @prisae pointed out in https://github.com/simpeg/simpeg/issues/1369#issuecomment-2003217696, we should make more emphasis on instructing contributors to make concise Pull Requests that solve only one thing. Maybe we could add a paragraph...
Currently the `test_regularization.py` contains a list of regularization classes that shouldn't be used to run a particular subset of tests. This list is growing large (as exposed by @jcapriot in...