Santiago Soler

Results 259 comments of Santiago Soler

Haha, apparently after closing https://github.com/fatiando/verde/pull/448, this PR was automatically closed. I'm reopening it since we do want to apply these changes despite the ones introduced in Verde. Reminder to be...

It was due to a failure when trying to push the coverage report to Codecov. I reran it and now it's passing. Nothing wrong with your code ❤️

This is starting to look great @indiauppal! I'm leaving a few ideas after the meeting we had today: 1. We should probably extend the test function for less than 5000...

@indiauppal, I'm updating this branch after the fix I made for the failing Mac testing. Remember to run a `git pull` to sync your local repo with the latest change...

I'm noticing that the attributes section only show a shorten description, without the mathematical definitions. I think we should fix that before merging this PR.

I restored the attributes list in the class template, so we can have both the attribute list generated by numpydoc (with just a single line description) and the extended descriptions...

No worries! And also remember you can download the built docs from the Actions' artifact: https://github.com/fatiando/boule/actions/runs/9421670139

> > One other thing I noticed is that the `normal_gravity`, `normal_gravity_potential` and `normal_gravitational_potential` defines the `q` and `q_0` quantities. Does it worth having private methods for those? Just raising...

I like the idea of @VascoSch92 to have a dataclass for each reference. This way we can choose to only output the minimal information about each reference like authors' names,...

I'm going to hard code the `github_version` to the latest release and check the built docs (Azure artifact) to see if the change works as expected. If it does I'll...