Santiago Soler
Santiago Soler
I'm closing this PR. It's been too long since we started it and it's probably harder to update the branch that to start it from scratch again. I'll leave the...
The newly added tests are failing due to the bug that should be fixed in #1460. Will wait for that PR to be merged before merging this one.
Thanks @LL-Geo! > For the rotation, I think I put a different file from the uploaded data with the picture I showed before. The actual data is not rotated in...
This is amazing @LL-Geo! Huge shout out to @markjessell for noticing that LZRW1 wasn't being use and for those 16 unexplained bytes. I will work on the coordinates for the...
@LL-Geo I added support for rotated grids and refactor a little bit your code. I also removed all the sample files that weren't being used in the tests. Did you...
> Looks great! Mostly over-my-head, but I read through what I could understand, and tested with a whole bunch of grids I had, all of which worked great. I noticed...
> For a 2D case anyway, could use rioxarray possibly to utilise this? I assume that you are talking about the projection codes, right @RichardScottOZ ? If so, yes, you...
Since we had a couple of positive reviews thanks to @LL-Geo and @mdtanker I'm merging this 🚀 . We have included some untested lines with this PR, but they are...
You're probably right. I guess Numba+LLVM is smart enough to note that there's a reduction happening in this line and they are not allocating the 2D array: https://github.com/simpeg/simpeg/blob/c8b1fab66f1175c84c6ed1107a9d2f6dffb9905e/simpeg/utils/model_utils.py#L222-L224 Nonetheless, they...
Thanks for commenting on this @lheagy. I can leave a few points I think might be relevant for this PR: - We need to update this against the latest `main`...