Santiago Soler

Results 200 comments of Santiago Soler

Thanks @YingHuuu! I'll take a look at the PR you opened and provide some feedback shortly.

> Just a few notes while you're working on this. Thanks @jcapriot for the early review!

@thibaut-kobold @jedman I've been working towards finishing this PR. I think it's ready to be reviewed. Would you like to take a look at it, give it a try and...

> @santisoler question / feature request: Will it work with `SimulationEquivalentSourceLayer`? That'd be awesome. > > I believe `SimulationEquivalentSourceLayer` work with a 2D mesh to which you set the top...

> It looks like these were written this way for a reason > > ![image](https://private-user-images.githubusercontent.com/12970009/294319904-7aaa5da9-b2d5-4cc5-a927-d662d4211c47.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDQ0ODA3NzksIm5iZiI6MTcwNDQ4MDQ3OSwicGF0aCI6Ii8xMjk3MDAwOS8yOTQzMTk5MDQtN2FhYTVkYTktYjJkNS00Y2M1LWE5MjctZDY2MmQ0MjExYzQ3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTA1VDE4NDc1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYzNWYxZTE0OGIyNTExMTQyNTcxMTFlZDdlYmExODYwNTcwZjVlOWVmNTg0ZGVmMzEwYmNmYzYyYTc0NTc2YTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.x6UDOI5CPnqyRxzWr-7Fmt-gbolH8kjf3z4qiieT9yU) I see. Then nevermind those if they fail. I think the `Zero` object should support...

This is looking great @ghwilliams! Thanks again for all the effort you put into this, and thanks @lheagy for the reviews. I'll merge it after CI passes.

Sure! Changing on tests (#1289) might be tricky, but at some we should do it.

> My name is already on there, but looks good. I think in the past we have encourage people to add their own name to the authors list, but we...

We are using Probot instead: https://github.com/probot No preference over anyone. Just noticed that [behaviorbot/welcome](https://github.com/behaviorbot/welcome) hasn't had a commit in ~ 3 years.

> Which probot bot are you using on Fatiando? There seems to be many different one, but I think this is the most relevant, https://probot.github.io/apps/welcome/ Yes, we are using the...