Santiago Soler
Santiago Soler
Thanks @YingHuuu! I'll take a look at the PR you opened and provide some feedback shortly.
> Just a few notes while you're working on this. Thanks @jcapriot for the early review!
@thibaut-kobold @jedman I've been working towards finishing this PR. I think it's ready to be reviewed. Would you like to take a look at it, give it a try and...
> @santisoler question / feature request: Will it work with `SimulationEquivalentSourceLayer`? That'd be awesome. > > I believe `SimulationEquivalentSourceLayer` work with a 2D mesh to which you set the top...
> It looks like these were written this way for a reason > >  I see. Then nevermind those if they fail. I think the `Zero` object should support...
This is looking great @ghwilliams! Thanks again for all the effort you put into this, and thanks @lheagy for the reviews. I'll merge it after CI passes.
Sure! Changing on tests (#1289) might be tricky, but at some we should do it.
> My name is already on there, but looks good. I think in the past we have encourage people to add their own name to the authors list, but we...
We are using Probot instead: https://github.com/probot No preference over anyone. Just noticed that [behaviorbot/welcome](https://github.com/behaviorbot/welcome) hasn't had a commit in ~ 3 years.
> Which probot bot are you using on Fatiando? There seems to be many different one, but I think this is the most relevant, https://probot.github.io/apps/welcome/ Yes, we are using the...