feature request: resize with the mouse

[MasseGuillaume]

:-)

[davidlukerice]

+1

[alearcy]

+1

[MasseGuillaume]

@santip take a look at https://github.com/atom/tree-view/blob/b50f69358f30077318b28f5642e41ee1cb94a310/lib/tree-view.coffee#L24

[nijikokun]

Bump

[rmartin]

Hi @santip and all,

I've been making steady progress on this and have posted my overall status update in the original Atom ticket thread (https://github.com/atom/atom/issues/274#issuecomment-74623686). You can find my latest commits references above which are in the feature fork/branch (https://github.com/rmartin/resize-panes/tree/issue-7-resize-with-mouse). I'm going to keep progress posted in the atom ticket and then update this thread once complete.

@santip , when you get a chance can you review my overall progress and ensure that this feature is inline with the overall goal of your project / package? I know you've separated several features out into individual modules and this is essentially a large re-write to accommodate for the mouse resize logic. Overall it makes sense to me to have this be a single plugin but I just want to ensure you're going to be okay with that approach from a pull request perspective.

Please note that my branch currently has the keyboard logic removed. This is just for simplification of testing and to accommodate the new Fluxbox resize approach. This will be added back in before I submit the pull request.

Cheers, Roy

[santip]

Hey Roy,

Your changes sure look interesting and I briefly looked through the code changes and it looks reasonable. Didn't have the time right now to test it, but if the implementation performs well this sounds like a great addition to the plugin and I agree it should be a single plugin.

A few questions:

• I see you're subscribing to pane changes to add/remove the resize panes, does this work properly on initial loading of an already split workspace?
  • How does the mouse resizing work, is there an additional border displayed or are you reusing the existing border space for the draggable area?
  • It would be ideal to have mouse-based resizing disabled via config.

Keep up the great work, looking forward to the PR

Thanks, Santi

On Tue Feb 17 2015 at 3:47:45 AM Roy Martin [email protected] wrote:

Hi @santip https://github.com/santip and all,

I've been making steady progress on this and have posted my overall status update in the original Atom ticket thread (atom/atom#274 (comment) https://github.com/atom/atom/issues/274#issuecomment-74623686). You can find my latest commits references above which are in the feature fork/branch ( https://github.com/rmartin/resize-panes/tree/issue-7-resize-with-mouse). I'm going to keep progress posted in the atom ticket and then update this thread once complete.

@santip https://github.com/santip , when you get a chance can you review my overall progress and ensure that this feature is inline with the overall goal of your project / package? I know you've separated several features out into individual modules and this is essentially a large re-write to accommodate for the mouse resize logic. Overall it makes sense to me to have this be a single plugin but I just want to ensure you're going to be okay with that approach from a pull request perspective.

Please note that my branch currently has the keyboard logic is currently removed. This is just for simplification of testing and to accommodate the new Fluxbox resize approach. This will be added back in before I submit the pull request.

Cheers, Roy

— Reply to this email directly or view it on GitHub https://github.com/santip/resize-panes/issues/7#issuecomment-74624474.

[rmartin]

Hey @santip ,

Thanks for the quick response. Here is my feedback on your notes above.

• Initial Load - Good point. In this latest refactor I didn't add the call for the initial load. I'll add that to the todo list in the main ticket.
• Resize Space - I insert a new pane into the view, that's 6 pixels and adds the draggable callbacks. This is the real trick to this as this is inserted based on the PaneAxis and not the editor grid. As a result I need to keep track of that and watch for updates in the PaneAxis which is more complicated but allows for more control.
• Good point, I haven't gotten that far in Atom Packages but i'll add that to the list of items before the PR.

Let me know if you're seeing anything else and i'll add that to the list.

Cheers, Roy