Santiago Gimeno

Results 108 comments of Santiago Gimeno

I'm investigating this. Can you post the output using `DEBUG=*` when using 20.2.0? Thanks!

Thanks for the logs. I've been looking into this and I'm a bit confused. By running the example in `20.2` with `strace` I can see that the library opens the...

The `test-abstract.js` should be added to the scripts -> test entry in `package.json`. Also testing the `EINVAL` case would be nice.

Still, a test for the `EINVAL` case would be nice.

It LGTM with the nit addressed, but I would prefer @bnoordhuis to sign off on this before merging. Thanks!!

@mvduin It makes sense. The problem I see is that the API would be different for UNIX and abstract sockets and that could be confusing.

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/2261/

> It is not necessarily windows-specific, since macOS already does this too (if you hit the posix_spawn code path) > Good point. I'll look into it, thanks!

> It is not necessarily windows-specific, since macOS already does this too (if you hit the posix_spawn code path) Following on this, what do you suggest? Just make clear in...