Santiago Bartesaghi
Santiago Bartesaghi
Hi @jamiemccarthy, no worries about timing, this is OSS, so we do the best that we can 😄 Thanks for continuing such an interesting conversation. > 1. Simplifying the enabling/disabling...
Hi @jamiemccarthy, >I'm happy to make this PR into the MVP and then look at other changes in later PRs. Want me to go ahead and do that? Yes, please...
Just thinking out loud, but another option that would help with the spiky throttles would be [optionally removing the period from the key](https://github.com/rack/rack-attack/issues/651#issuecomment-1913741759). Did you consider this option? I guess...
Interested in hearing more about the differences as well
Hey @johnnyshields, I’d like to make clear that not necessarily all of the proposed PRs will get merged. We’ll need to evaluate the tradeoffs of each of them. Regarding this...
Hi @arnoFleming, you are right about the behavior of rack attack. It's all about [how the cache key is formed](https://github.com/rack/rack-attack/blob/main/lib/rack/attack/cache.rb#L73). Some time ago, when I searched back to understand why...
Hi @NOX73 and @seliverstov-maxim 👋 First of all, thanks for your contribution. I've been thinking about this PR for some days already, but didn't comment because I haven't formed an...
@NOX73 Honestly, I'm not sold on adding this feature to `rack-attack`. I'm wondering, would it be possible to add this feature as a separate gem? I mean something like a...
> @santib This opens up an interesting problem -- how do we chunk code? Yeah, I just used the Text one for simplicity, but checking https://python.langchain.com/docs/modules/data_connection/document_transformers/text_splitters/code_splitter seems like they [get...
Another option would be to have `rails active_storage:install` generate a `app/controllers/active_storage/base_controller.rb` with a content like ```ruby # frozen_string_literal: true # The base class for all Active Storage controllers. # You...