jsonschema icon indicating copy to clipboard operation
jsonschema copied to clipboard

errors: captures error message fields in struct

Open santhosh-tekuri opened this issue 2 years ago • 3 comments

closes Issue #44

santhosh-tekuri avatar Jan 10 '23 07:01 santhosh-tekuri

Codecov Report

Base: 91.66% // Head: 91.66% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (be93380) compared to base (2dc9222). Patch coverage: 96.96% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   91.66%   91.66%   -0.01%     
==========================================
  Files          10       10              
  Lines        2545     2542       -3     
==========================================
- Hits         2333     2330       -3     
  Misses        164      164              
  Partials       48       48              
Impacted Files Coverage Δ
output.go 0.00% <0.00%> (ø)
errors.go 85.29% <100.00%> (+0.21%) :arrow_up:
extension.go 14.81% <100.00%> (ø)
schema.go 98.69% <100.00%> (-0.01%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Jan 10 '23 07:01 codecov-commenter

@santhosh-tekuri : What is needed to land this diff? I can help.

akshetpandey avatar Mar 24 '23 18:03 akshetpandey

@akshetpandey you can use v6.0.0-alpha.1 if you need this change.

currently I am porting this to rust https://github.com/santhosh-tekuri/boon and found some bugs and some improvements which also require incompatible changes.

so I am holding on so that I can do all incompatible changes in single major release.

santhosh-tekuri avatar Mar 24 '23 21:03 santhosh-tekuri