Sanskar Jethi
Sanskar Jethi
Feedback from Reddit ------------------------------------------------ I like the look and feel of the documentation, but the navigation link is at the bottom on my android with firefox. It confused me for...
Thank you @awestlake87! :smile:
@awestlake87 absolutely. I am getting some deprecation warnings in the update. ```bash --> src/lib.rs:25:5 | 25 | pyo3_asyncio::try_init(py)?; | ^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default warning: use of...
@awestlake87 , removing pyo3_asyncio::try_init and replacing pyo3_asyncio::run_forever with the tokio snippet doesn't make the async loop run. Earlier, I used to run the snippet: ``` pub fn start(&mut self, py:...
@awestlake87 , sure. I just replaced the line `run_forever(py).unwrap()` in the first example with the `let asyncio = py.import("asyncio").unwrap();.....` line in the second. I have kept everything else the same.
Also, if `pyo3_asyncio::run_forever` has been deprecated. Should I be doing something like `pyo3_asyncio::tokio:run_until_complete(loop{})` ?
@awestlake87 , I got rid of that error. But it is telling me that: `Error: RuntimeError: no running event loop`
@awestlake87 , sure. Here is the PR, where I am trying to do the migration: https://github.com/sansyrox/robyn/pull/65 Here is the main repo: https://github.com/sansyrox/robyn
Thank you @ShadowJonathan ! Got it. 😄
@ShadowJonathan , sorry I closed the issue by mistake. I was wondering if it will be possible(through a clever bypass maybe) to not acquire gil everytime and maybe acquire it...