Kensei Nakada
Kensei Nakada
> shall we add a note to ScenarioPodScheduleResult that AllCandidateNodes,AllFilteredNodes,PluginResult will be all blank if the scheduler is NOT scheduling framework based one? 👍 will do it later.
- add appropriate jsontag, `+optional`, `patchStrategy`. - add the comment for https://github.com/kubernetes-sigs/kube-scheduler-simulator/pull/194#pullrequestreview-1033752942
@196Ikuchil @everpeace Updated in https://github.com/kubernetes-sigs/kube-scheduler-simulator/pull/194/commits/87017e9b121326fbf41b4d22fc73f3c2da3a9e9d. Please take a look again when have a chance. - create `StepPhase` and use it instead of `schedulerStatus`. - The names are changed, but the...
/retitle elaborate more on how to/when stop scheduling
/retitle Changed the design to allow Scenario to be used with more kind of controllers
@everpeace @196Ikuchil Applied a big update.... 🙇 🙏 Please take a look again.
@everpeace @196Ikuchil Sorry for toooooo late updating. I think I addressed/replied all your reviews. Please retake a look 🙏
/triage accepted Not to mark as stale.
/retitle Support external scheduler