TD-PSOLA icon indicating copy to clipboard operation
TD-PSOLA copied to clipboard

Incorrect windowing for pitch ratios less than 1

Open MysteryPancake opened this issue 4 years ago • 0 comments

Hello!

Firstly, thanks very much for this implementation. It has really helped me understand PSOLA!

However, I found a bug in the windowing. It is best explained by this diagram: useddiagram

The issue is due to the windowing being incorrect for all pitch ratios lower than 1. In this case, the peaks array must be used to calculate windowing, requiring different math.

I've put a bit more explanation on Stack Exchange.

MysteryPancake avatar Aug 24 '20 10:08 MysteryPancake