websocket_client icon indicating copy to clipboard operation
websocket_client copied to clipboard

Error decoding fragmented frames

Open jeanparpaillon opened this issue 4 years ago • 5 comments

See https://github.com/sanmiguel/websocket_client/issues/70

jeanparpaillon avatar Sep 03 '21 11:09 jeanparpaillon

Did you mean to include the decode_frame -> decode_header change?

Also, wow, nice find!

fhunleth avatar Sep 03 '21 12:09 fhunleth

@fhunleth if you don't mind, we can include the function name change, but you can pick the second commit only, if you prefer

btw, I would have liked adding a non-regression test (I have some sample data for this), but I was unable to run the tests. Got this error:

$ rebar3 ct 
===> Verifying dependencies...
===> Compiling websocket_client
src/websocket_client.erl:134:10: Warning: http_uri:parse/2 is deprecated and will be removed in OTP 25; use uri_string functions instead

src/wsc_lib.erl:7:2: Warning: export_all flag enabled - all functions will be exported

build/test/lib/websocketclient/test/wsreq_SUITE.erl:3:2: Warning: export_all flag enabled - all functions will be exported

build/test/lib/websocketclient/test/wsc_lib_SUITE.erl:3:2: Warning: export_all flag enabled - all functions will be exported

===> Running Common Test suites...
===> Error running tests:
  "Failed to start CTH, see the CT Log for details"

jeanparpaillon avatar Sep 03 '21 12:09 jeanparpaillon

Sorry - I don't maintain this project. I just saw the fix and was trying to be helpful to get it merged as quickly as possible.

fhunleth avatar Sep 03 '21 12:09 fhunleth

I am finally making my way back to get this library up-to-date. Will pick up this PR soon.... thanks Jean!

sanmiguel avatar Aug 05 '22 11:08 sanmiguel

@sanmiguel you're welcome :pray:

jeanparpaillon avatar Aug 05 '22 11:08 jeanparpaillon