Alexey Kopytko

Results 199 comments of Alexey Kopytko

That's an interesting feature and I will happily review a PR with it implemented.

CI must pass, and there's some basic guidance when you make a PR.

This implementations is expected to behave just like the Ruby's. Please try referring to the Shopify Liquid docs: https://help.shopify.com/themes/liquid/tags/theme-tags#include Note that there are at least [three variants of Liquid](http://shopify.github.io/liquid/basics/variations/). If...

Can't tell without a code! Please file an issue with an example code. Or even better: make a PR with a failing example.

> Looking for `Liquid\Template` in `src/Liquid/Template.php` Isn't this is [what we have in actuality](https://github.com/kalimatas/php-liquid/tree/master/src/Liquid)?

It should be possible to adopt benchmarks used by Twig. I think this claim is for [the original implementation](https://github.com/Shopify/liquid), so I'd take it with a grain of salt regarding this...