Sander Maijers

Results 291 comments of Sander Maijers

Is there a development on this issue? Prettier exits with an error exit status if a symlink is between, e.g. `{all_files}`.

@mrexox Yes, see https://github.com/evilmartians/lefthook/issues/539 for a well-argued use case and solution direction. I don't know if a boolean would be optimal, since a Git file mode filter would be more...

@bbros-dev What do you mean with build the list? Do you mean adding the placeholder `{staged_files}` to every `run` command? If `run`'s value were of type list instead of string...

New location of docs: https://github.com/evilmartians/lefthook/blob/master/docs/configuration.md#piped

@mrexox By imposing an order by design, commands that are order-dependent cannot always work. For example, a command may have an auto-fixer and only after that fixer is done (e.g.,...

@BnGx What's the value of a `priority` key over an ordered datastructure, like a list?

@BnGx It would not, the data type of `commands` would be `[dict | list[dict]]` in Python terms. I.e., the union of both types. This means that the dict-based schema is...

`.lefthook/example.lefthook.yml`: ```yaml database: piped: true commands: - name: create run: rake db:create - name: review interactive: true run: - name: migrate run: rake db:migrate - test: interactive: true run: -...

@BnGx I think the arguments you make don't weigh up against breaking backward compatibility. As a middle ground, the dictionary-based `commands` can be deprecated in favor of the list of...

Older configurations can be run by an older version of Lefthook. But that's only an issue at all if you deprecate the current format, which is one of your suggestions.