Sam Suhag

Results 36 comments of Sam Suhag

The JSDoc to `.d.ts` pipeline seems to have [several open issues](https://github.com/microsoft/TypeScript/labels/Domain%3A%20Comment%20Emit). I left a [comment](https://github.com/microsoft/TypeScript/issues/46010) providing an example of the issue we're running into.

Currently, https://github.com/CesiumGS/cesium/pull/9873 has functionality that enables `B3dmLoader` to do this for B3DMs with Batch IDs but no Batch Table. That should be replaced by this functionality in `GltfLoader`

@andersan No fix for this yet. Setting `scene.globe.showGroundAtmosphere` should disable the atmosphere effect on the terrain.

Another benefit this may have is that it would allow us to upgrade our testing tools. We could take advantage of something like Jest, which could run tests in parallel....

I am currently prototyping on the `workspaces` branch. I initially tested things on a simple npm package I created, now I'm trying to test things on the cesium repo. At...

The cause of this issue is the regex filter for the instrumented plugin not working for the Windows path separator: https://github.com/CesiumGS/cesium/blob/0fcd8ca4d0d64f0d9b10c04608f938337f629c2a/gulpfile.js#L1148 I believe all the `\\` should be `(\\|\/)` instead.

Based on offline discussion, it seems like GitHub Actions might be an easier option, if we switch to Conan https://github.com/CesiumGS/cdb-to-3dtiles/issues/56.

Do you know which type of GLBs are affected? Is the `GSModels` or the `GTModels`?

@nithinp7 Did retiling on that branch help resolve your issue?

Closing as duplicate of https://github.com/CesiumGS/cesium/issues/10064.