ng-image-slider icon indicating copy to clipboard operation
ng-image-slider copied to clipboard

upgraded to angular 17

Open EphraimHaber opened this issue 1 year ago • 2 comments

I've added support to angular 17, built and it works. I went ahead and published it to npm so my team can use it but here are the changes

EphraimHaber avatar Jan 06 '24 05:01 EphraimHaber

The issue with the new package is jest is failing to load it. I suspect somewhere it's still attempting to load it as ng-image-slider (and not ng-image-slider-v17)

FAIL  src/app/app.component.spec.ts
  ● Test suite failed to run

    Cannot find module 'ng-image-slider' from 'src/app/pages/venue-location/detail/location-detail.component.ts'

If I rename the folder without the v17 and rename the package.json without v17

jamesrusso avatar May 01 '24 18:05 jamesrusso

@sanjayV should roll a new release with the updated package.json with changes from @EphraimHaber

jamesrusso avatar May 01 '24 18:05 jamesrusso