ng-image-slider
ng-image-slider copied to clipboard
sanjayV
Angular 17 compatability
Hi, we're very happily using your image slider. However it doesn't work on the latest version of Angular 17. Could you please update the project so we can keep using it?
I've opened a pull request, you can go ahead and try it out by running
npm i ng-image-slider-v17
didn't change anything other then the deps. nor did I edit the README #194
Hi @EphraimHaber, I tried that, but still got this message, not sure if you can tell what's wrong:
Can't tell where that @angular/[email protected] comes from
@mmorac That is because you did NOT uninstall ng-image-slider.
as you can see in your root project you have ng-image-slider, not ng-image-slider-v17 which is what I published.
Please share when can we expect a release stable version which supports Angular 17. The one shared above is coming from a different package name. Can the same PR be merged.
@mmorac Try installing this
npm i ng-image-slider-v17
yes I have tried that & it is working. When we moved from Angular v15 to v16 , I also had a switch to using ng-image-slider-v16 . However I do not feel this approach is a sustainable one. Instead why is the original package not publishing new version. I see both for v16 & v17 , new packages are created instead of bumping up versions of existing packages. There are open PRs for both the version waiting to be merged.
Angular v18 is coming up next week so are we expecting a new package ng-image-slider-v18 then ?
@mgardi85 Correct. Ideally this PR should be accepted, if I'll make the time I can just publish it under a new name. That was just a quick hack since I needed this package to be angular 17 compatible ASAP