sanity
sanity copied to clipboard
fix(portable-text-editor): fix safari focus issue on empty editor
Description
This fixes a issue in Safari where focus in a activated, empty PTE input a second time won't allow you to type unless you click the "Empty" placeholder precisely.
Fixes EDX-122.
What to review
- That focus behaviour behaves the same was as before in all the normal browsers
- That focus activates properly on repeated tabbing into the same empty input
Notes for release
- Fixes an issue where focus on a empty Portable Text Input won't work consistently in Safari
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| performance-studio | ✅ Ready (Inspect) | Visit Preview | Dec 13, 2023 0:45am | |
| test-studio | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Dec 13, 2023 0:45am |
1 Ignored Deployment
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| studio-workshop | ⬜️ Ignored (Inspect) | Visit Preview | Dec 13, 2023 0:45am |
| Package | Documentation Change |
|---|---|
| sanity | -3% |
Full Report
@sanity/diff
| This branch | Next branch |
|---|---|
| 13 documented | 13 documented |
| 16 not documented | 16 not documented |
@sanity/block-tools
| This branch | Next branch |
|---|---|
| 4 documented | 4 documented |
| 9 not documented | 9 not documented |
@sanity/types
| This branch | Next branch |
|---|---|
| 54 documented | 54 documented |
| 235 not documented | 235 not documented |
sanity/desk
| This branch | Next branch |
|---|---|
| 85 documented | 85 documented |
| 60 not documented | 60 not documented |
@sanity/portable-text-editor
| This branch | Next branch |
|---|---|
| 21 documented | 21 documented |
| 44 not documented | 44 not documented |
@sanity/mutator
| This branch | Next branch |
|---|---|
| 7 documented | 7 documented |
| 4 not documented | 4 not documented |
@sanity/cli
| This branch | Next branch |
|---|---|
| 1 documented | 1 documented |
| 30 not documented | 30 not documented |
@sanity/schema/_internal
| This branch | Next branch |
|---|---|
| 0 documented | 0 documented |
| 9 not documented | 9 not documented |
@sanity/util/paths
| This branch | Next branch |
|---|---|
| 1 documented | 1 documented |
| 15 not documented | 15 not documented |
sanity/router
| This branch | Next branch |
|---|---|
| 17 documented | 17 documented |
| 26 not documented | 26 not documented |
@sanity/util/legacyDateFormat
| This branch | Next branch |
|---|---|
| 0 documented | 0 documented |
| 3 not documented | 3 not documented |
@sanity/schema
| This branch | Next branch |
|---|---|
| 0 documented | 0 documented |
| 2 not documented | 2 not documented |
sanity/cli
| This branch | Next branch |
|---|---|
| 2 documented | 2 documented |
| 0 not documented | 0 not documented |
@sanity/vision
| This branch | Next branch |
|---|---|
| 0 documented | 0 documented |
| 3 not documented | 3 not documented |
@sanity/util/fs
| This branch | Next branch |
|---|---|
| 0 documented | 0 documented |
| 3 not documented | 3 not documented |
sanity/_internal
| This branch | Next branch |
|---|---|
| 0 documented | 0 documented |
| 1 not documented | 1 not documented |
@sanity/util/content
| This branch | Next branch |
|---|---|
| 1 documented | 1 documented |
| 5 not documented | 5 not documented |
sanity
| This branch | Next branch |
|---|---|
| 169 documented | 176 documented |
| 837 not documented | 844 not documented |
Component Testing Report Updated Dec 13, 2023 12:46 PM (UTC)
| File | Status | Duration | Passed | Skipped | Failed |
|---|---|---|---|---|---|
| comments/CommentInput.spec.tsx | ✅ Passed (Inspect) | 14s | 15 | 0 | 0 |
| formBuilder/ArrayInput.spec.tsx | ✅ Passed (Inspect) | 2s | 3 | 0 | 0 |
| formBuilder/inputs/PortableText/Annotations.spec.tsx | ✅ Passed (Inspect) | 8s | 3 | 0 | 0 |
| formBuilder/inputs/PortableText/Decorators.spec.tsx | ✅ Passed (Inspect) | 6s | 6 | 0 | 0 |
| formBuilder/inputs/PortableText/FocusTracking.spec.tsx | ✅ Passed (Inspect) | 15s | 15 | 0 | 0 |
| formBuilder/inputs/PortableText/Input.spec.tsx | ✅ Passed (Inspect) | 8s | 9 | 0 | 0 |
| formBuilder/inputs/PortableText/ObjectBlock.spec.tsx | ✅ Passed (Inspect) | 39s | 18 | 0 | 0 |
| formBuilder/inputs/PortableText/Styles.spec.tsx | ✅ Passed (Inspect) | 6s | 6 | 0 | 0 |
| formBuilder/inputs/PortableText/Toolbar.spec.tsx | ✅ Passed (Inspect) | 3s | 3 | 0 | 0 |
The placeholder seems to be pushed down on Chrome:
@sjelfull Is this still relevant? /cc @christianhg
@rexxars I believe so, re-assigning to @christianhg