sanity
sanity copied to clipboard
sanity-io
fix(deps): upgrade `vite` to v5
Description
Vite v5 is full of goodies, perf and fixes.
And v5.1
What to review
sanity dev should hot reload faster, sanity build should be significantly faster. The existing public API shouldn't break and v3 plugins should continue to bundle.
It can be tested using pnpm i [email protected]
Notes for release
fix(deps): upgrade to vite v5 for speedier sanity dev and sanity build DX ✨
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| page-building-studio | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 1, 2024 8:06am |
| performance-studio | ✅ Ready (Inspect) | Visit Preview | Aug 1, 2024 8:06am | |
| test-compiled-studio | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 1, 2024 8:06am |
| test-next-studio | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 1, 2024 8:06am |
| test-studio | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 1, 2024 8:06am |
1 Skipped Deployment
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| studio-workshop | ⬜️ Ignored (Inspect) | Visit Preview | Aug 1, 2024 8:06am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
| Package | New capabilities | Transitives | Size | Publisher |
|---|---|---|---|---|
| npm/[email protected] | None | +1 |
52 kB | sindresorhus |
| npm/[email protected] | environment, filesystem | +2 |
149 kB | paulmillr |
| npm/[email protected] | None | 0 |
23.6 kB | jedwatson |
| npm/[email protected] | None | 0 |
6.37 kB | sindresorhus |
![socket-security[bot] avatar](https://avatars.githubusercontent.com/in/156372?v=4 "Published by a pub.dev verified publisher"){kind=small}
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Component Testing Report Updated Aug 1, 2024 8:09 AM (UTC)
| File | Status | Duration | Passed | Skipped | Failed |
|---|---|---|---|---|---|
| comments/CommentInput.spec.tsx | ✅ Passed (Inspect) | 52s | 15 | 0 | 0 |
| formBuilder/ArrayInput.spec.tsx | ✅ Passed (Inspect) | 8s | 3 | 0 | 0 |
| formBuilder/inputs/PortableText/Annotations.spec.tsx | ✅ Passed (Inspect) | 31s | 6 | 0 | 0 |
| formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx | ✅ Passed (Inspect) | 36s | 11 | 7 | 0 |
| formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx | ✅ Passed (Inspect) | 0s | 0 | 12 | 0 |
| formBuilder/inputs/PortableText/Decorators.spec.tsx | ✅ Passed (Inspect) | 17s | 6 | 0 | 0 |
| formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx | ✅ Passed (Inspect) | 10s | 3 | 0 | 0 |
| formBuilder/inputs/PortableText/DragAndDrop.spec.tsx | ✅ Passed (Inspect) | 3m 0s | 0 | 0 | 0 |
| formBuilder/inputs/PortableText/FocusTracking.spec.tsx | ✅ Passed (Inspect) | 44s | 15 | 0 | 0 |
| formBuilder/inputs/PortableText/Input.spec.tsx | ✅ Passed (Inspect) | 1m 46s | 21 | 0 | 0 |
| formBuilder/inputs/PortableText/ObjectBlock.spec.tsx | ✅ Passed (Inspect) | 1m 15s | 18 | 0 | 0 |
| formBuilder/inputs/PortableText/PresenceCursors.spec.tsx | ✅ Passed (Inspect) | 8s | 3 | 9 | 0 |
| formBuilder/inputs/PortableText/RangeDecoration.spec.tsx | ✅ Passed (Inspect) | 26s | 9 | 0 | 0 |
| formBuilder/inputs/PortableText/Styles.spec.tsx | ✅ Passed (Inspect) | 18s | 6 | 0 | 0 |
| formBuilder/inputs/PortableText/Toolbar.spec.tsx | ✅ Passed (Inspect) | 1m 12s | 21 | 0 | 0 |
| formBuilder/tree-editing/TreeEditing.spec.tsx | ✅ Passed (Inspect) | 1m 47s | 30 | 0 | 0 |
| formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx | ✅ Passed (Inspect) | 19s | 3 | 0 | 0 |
Getting errors of The CJS build of Vite's Node API is deprecated. Not sure quite how to resolve this - esbuild-register kind of messes up the stack trace, and the way we bundle everything into a single file kind of makes things even more complicated.
I think ideally we'd move towards an ESM-first CLI that does not bundle build the CLI to a single file (previously this was done because npm2 used an absurd amount of time installing dependencies - that story is now better, and we have less dependencies than back then too).
Having said that, if we can make it still make it work with today's solution, I'd be more than happy to look at the altered approach.
@skogsmaskin, yes, I'll update the PR again when I have time between larger tasks, or waiting for a review on a larger PR 😄